Add Safe Actions (Create Tx, Sign Tx, and Execute Tx)#2
Open
escottalexander wants to merge 18 commits intoazf20:mainfrom
Open
Add Safe Actions (Create Tx, Sign Tx, and Execute Tx)#2escottalexander wants to merge 18 commits intoazf20:mainfrom
escottalexander wants to merge 18 commits intoazf20:mainfrom
Conversation
escottalexander
force-pushed
the
create-safe-action
branch
from
50673d4 to
91e0508
Compare
escottalexander
force-pushed
the
create-safe-action
branch
from
fe1375d to
38c8aaa
Compare
escottalexander
changed the title
Collaborator
Author
|
This is finally working after doing a lot from scratch. I know a lot more about Safe now though. |
escottalexander
commented
Feb 9, 2025
| * @param message - The message to sign. | ||
| * @returns The signed message. | ||
| */ | ||
| async signMessage(message: string | { raw: `0x${string}` }): Promise<`0x${string}`> { |
Collaborator
Author
There was a problem hiding this comment.
If you can't tell. Instead of extending ViemWalletProvider (from agentkit) I just added all the methods here then changed this one method so that you can pass the { raw: 0x${string} } object in. This was required to get a valid signature. It seems ludicrous that CB doesn't support it out of the box since Viem does.
|
@azf20 is attempting to deploy a commit to the azf20's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't work but wanted to make it visible in case someone is inspired to take a look at the issue. The issue I am seeing is that I am initializing Safe with a public provider and so it does not support signing methods (because there is no wallet attached). You can see how I get around it in the createSafe action but the rest are not working.